Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding movement #27126

Merged
merged 10 commits into from
Jul 31, 2024
Merged

Adding movement #27126

merged 10 commits into from
Jul 31, 2024

Conversation

niksirbi
Copy link
Contributor

@niksirbi niksirbi commented Jul 30, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/movement/meta.yaml) and found some lint.

Here's what I've got...

For recipes/movement/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [37, 38, 39, 40, 41, 42, 43, 44]
  • The following maintainers have not yet confirmed that they are willing to be listed here: adamltyson, lochhh. Please ask them to comment on this PR if they are.
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/movement/meta.yaml) and found some lint.

Here's what I've got...

For recipes/movement/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: adamltyson, lochhh. Please ask them to comment on this PR if they are.

@niksirbi
Copy link
Contributor Author

@adamltyson and @lochhh , could you confirm that you are happy to be maintainers for the movement's conda feedstock?

@adamltyson
Copy link
Member

Yep 🎉

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/movement/meta.yaml) and found some lint.

Here's what I've got...

For recipes/movement/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: lochhh. Please ask them to comment on this PR if they are.

@lochhh
Copy link

lochhh commented Jul 31, 2024

@adamltyson and @lochhh , could you confirm that you are happy to be maintainers for the movement's conda feedstock?

yup

@adamltyson
Copy link
Member

@conda-forge/help-python, ready for review!

@niksirbi niksirbi marked this pull request as ready for review July 31, 2024 09:34
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/movement/meta.yaml) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit 4ef6ab2 into conda-forge:main Jul 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants