Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dydxprotocol v4 client py #27129

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MementoRC
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydxprotocol-v4-client-py/meta.yaml) and found it was in an excellent condition.

@MementoRC MementoRC changed the title Add dydxprotocol v4 client py Add dydxprotocol v4 client py: WIP awaiting dydzprotocol-v4-proto Jul 31, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dydxprotocol-v4-client-py/meta.yaml) and found some lint.

Here's what I've got...

For recipes/dydxprotocol-v4-client-py/meta.yaml:

  • Please do not delete the example recipe found in recipes/example/recipe.yaml.

@MementoRC
Copy link
Contributor Author

@xhochy How to resolve this issue? I don't think I deleted anything. I'll adda recipe.yaml in example, but it does not make much sense to me

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydxprotocol-v4-client-py/meta.yaml) and found it was in an excellent condition.

@MementoRC MementoRC closed this Aug 13, 2024
@MementoRC MementoRC reopened this Aug 13, 2024
@xhochy
Copy link
Member

xhochy commented Aug 19, 2024

@xhochy How to resolve this issue? I don't think I deleted anything. I'll adda recipe.yaml in example, but it does not make much sense to me

This is resolved and other failures depend on missing dependencies, right?

@MementoRC
Copy link
Contributor Author

@xhochy How to resolve this issue? I don't think I deleted anything. I'll adda recipe.yaml in example, but it does not make much sense to me

This is resolved and other failures depend on missing dependencies, right?

Yes, it is, thx and welcome back. It's pending v4-proto

@MementoRC
Copy link
Contributor Author

Awaiting: #27100

@MementoRC MementoRC changed the title Add dydxprotocol v4 client py: WIP awaiting dydzprotocol-v4-proto Add dydxprotocol v4 client py: WIP awaiting dydxprotocol-v4-proto-py Aug 19, 2024
@MementoRC MementoRC closed this Aug 25, 2024
@MementoRC MementoRC reopened this Aug 25, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydxprotocol-v4-client-py/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/dydxprotocol-v4-client-py/meta.yaml:

  • No valid build backend found for Python recipe for package dydxprotocol-v4-client-py using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@MementoRC MementoRC changed the title Add dydxprotocol v4 client py: WIP awaiting dydxprotocol-v4-proto-py Add dydxprotocol v4 client py Aug 29, 2024
@MementoRC
Copy link
Contributor Author

v4-proto is live

@MementoRC MementoRC closed this Aug 29, 2024
@MementoRC MementoRC reopened this Aug 29, 2024
@MementoRC
Copy link
Contributor Author

@conda-forge/help-python , hello, ready for review

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydxprotocol-v4-client-py/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/dydxprotocol-v4-client-py/meta.yaml:

  • No valid build backend found for Python recipe for package dydx-v4-client using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants