Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkify-it-py as explicit dependency #150

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

pmoris
Copy link
Contributor

@pmoris pmoris commented Oct 29, 2024

The PyPi version of textual lists linkify-it-py as an extra dependency of markdown-it-py, but since the [extra-component] syntax used by pip is not supported by conda, this dependency was missing in the conda-forge recipe. See https://github.com/Textualize/textual/blob/main/pyproject.toml#L44.

This was causing issues with the (bio)conda recipe of a downstream packages that relied on textual and trogon (see nf-core/tools#3257).

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • requirements: run: linkify-it-py>=1,<3 must contain a space between the name and the pin, i.e. linkify-it-py >=1,<3

The PyPi version of textual lists linkify-it-py
as an extra dependency of markdown-it-py, but since
the [extra-component] syntax used by pip is not supported
by conda, this dependency was missing in the conda-forge recipe.
See https://github.com/Textualize/textual/blob/main/pyproject.toml#L44.
@pmoris pmoris force-pushed the linkify-dependency branch from 210a4ca to 1ae8d86 Compare October 29, 2024 13:39
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@davidbrochart
Copy link
Member

Thanks @pmoris.
There is also the plugins extra dependency, but I don't know if we should add it: markdown-it-py = { extras = ["plugins", "linkify"], version = ">=2.1.0" }.

@pmoris
Copy link
Contributor Author

pmoris commented Oct 29, 2024

@conda-forge-admin, please rerender

@pmoris
Copy link
Contributor Author

pmoris commented Oct 29, 2024

Thanks @pmoris. There is also the plugins extra dependency, but I don't know if we should add it: markdown-it-py = { extras = ["plugins", "linkify"], version = ">=2.1.0" }.

Good catch! I only tested with the nf-core tools package, which didn't end up requiring plugins. But that doesn't mean other packages might not require it... I'll add it too.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11575176339.

Besides `linkify`, textual also specifies `plugins` as an
additional extra component of `markdown-it-py` (See
https://github.com/Textualize/textual/blob/main/pyproject.toml#L44).
Unlike `linkify`, there is no version pinning though (See
https://github.com/executablebooks/markdown-it-py/blob/c10312e2e475a22edb92abede15d3dcabd0cac0c/pyproject.toml#L47).
@@ -24,6 +24,8 @@ requirements:
- platformdirs >=3.6.0,<5
- python >=3.8.1,<4.0.0
- markdown-it-py >=2.1.0
- linkify-it-py >=1,<3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get this pinning from?

Copy link
Contributor Author

@pmoris pmoris Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

textual pins markdown-it-py = { extras = ["plugins", "linkify"], version = ">=2.1.0" } (https://github.com/Textualize/textual/blob/main/pyproject.toml#L44).

And markdown-it-py specifies:

linkify = ["linkify-it-py>=1,<3"]
plugins = ["mdit-py-plugins"]

(https://github.com/executablebooks/markdown-it-py/blob/c10312e2e475a22edb92abede15d3dcabd0cac0c/pyproject.toml#L47).

Does that seem correct to you? Or is it unnecessary to pin something like this in the first place (I'm not overly familiar with how these dependencies end up getting resolved in the end).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect, thanks so much!

@davidbrochart davidbrochart merged commit 4d01ae4 into conda-forge:main Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants