-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linkify-it-py as explicit dependency #150
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
The PyPi version of textual lists linkify-it-py as an extra dependency of markdown-it-py, but since the [extra-component] syntax used by pip is not supported by conda, this dependency was missing in the conda-forge recipe. See https://github.com/Textualize/textual/blob/main/pyproject.toml#L44.
210a4ca
to
1ae8d86
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks @pmoris. |
@conda-forge-admin, please rerender |
Good catch! I only tested with the nf-core tools package, which didn't end up requiring |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11575176339. |
Besides `linkify`, textual also specifies `plugins` as an additional extra component of `markdown-it-py` (See https://github.com/Textualize/textual/blob/main/pyproject.toml#L44). Unlike `linkify`, there is no version pinning though (See https://github.com/executablebooks/markdown-it-py/blob/c10312e2e475a22edb92abede15d3dcabd0cac0c/pyproject.toml#L47).
@@ -24,6 +24,8 @@ requirements: | |||
- platformdirs >=3.6.0,<5 | |||
- python >=3.8.1,<4.0.0 | |||
- markdown-it-py >=2.1.0 | |||
- linkify-it-py >=1,<3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you get this pinning from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
textual
pins markdown-it-py = { extras = ["plugins", "linkify"], version = ">=2.1.0" }
(https://github.com/Textualize/textual/blob/main/pyproject.toml#L44).
And markdown-it-py
specifies:
linkify = ["linkify-it-py>=1,<3"]
plugins = ["mdit-py-plugins"]
Does that seem correct to you? Or is it unnecessary to pin something like this in the first place (I'm not overly familiar with how these dependencies end up getting resolved in the end).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's perfect, thanks so much!
The PyPi version of
textual
listslinkify-it-py
as an extra dependency ofmarkdown-it-py
, but since the [extra-component] syntax used by pip is not supported by conda, this dependency was missing in the conda-forge recipe. See https://github.com/Textualize/textual/blob/main/pyproject.toml#L44.This was causing issues with the (bio)conda recipe of a downstream packages that relied on
textual
andtrogon
(see nf-core/tools#3257).Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)