Skip to content
This repository has been archived by the owner on Apr 7, 2023. It is now read-only.

Sunsetting this feedstock? #19

Closed
jakirkham opened this issue Apr 5, 2023 · 7 comments · Fixed by conda-forge/admin-requests#702
Closed

Sunsetting this feedstock? #19

jakirkham opened this issue Apr 5, 2023 · 7 comments · Fixed by conda-forge/admin-requests#702

Comments

@jakirkham
Copy link
Member

jakirkham commented Apr 5, 2023

In PR ( conda-forge/staged-recipes#21953 ), cuda-cccl-impl is being added, which contains and supersedes thrust.

Also this feedstock has been updated so that thrust conflicts with cuda-cccl-impl (or other CCCL packages) ( #18 ). This conflict has also been applied as a repodata patch to old packages ( conda-forge/conda-forge-repodata-patches-feedstock#428 ).

Since the current plan is not to update this any further, how do we want to go about sunsetting this feedstock?

  • Do we want to alias this package?
  • Should this package emit some kind of deprecation warning?
  • Would it make sense to run a migration to move to the preferred package?
  • Do we want to archive this feedstock?
  • Anything else we should do?
  • Also any thoughts on the order/timeline of these?

Edit: Related cub issue ( conda-forge/cub-feedstock#24 )

@jakirkham
Copy link
Member Author

cc @bdice @leofang @kkraus14

@kkraus14
Copy link
Contributor

kkraus14 commented Apr 5, 2023

Given the plans related to thrust, cub, and libcudacxx that the team has publicly stated in wanting to move to a single package in the future, I would vote to archive this feedstock.

As far as a migration goes, we are quite far behind in packaging thrust / cub versions, they aren't in the global pinning, and there's a small number of recipes that use them. I don't think a migration would be particularly helpful / useful in this situation.

@bdice
Copy link
Contributor

bdice commented Apr 5, 2023

Agreed with @kkraus14. Let's archive thrust/cub and file follow-up issues for the three packages depending on thrust/cub. I would not do a migration, it's probably not needed.

@kkraus14
Copy link
Contributor

kkraus14 commented Apr 6, 2023

@rongou @leofang you're the other two maintainers on this and the cub feedstocks. Does this plan work for you?

@leofang
Copy link
Member

leofang commented Apr 6, 2023

Despite I start making bad decisions tonight, I think this is a right move to sunset/archive this feedstock. I argued that we should set up a migrator, but it might require some manual work in each feedstock, so perhaps not much automation can help.

@rongou
Copy link
Contributor

rongou commented Apr 6, 2023

Sounds good to me.

@kkraus14
Copy link
Contributor

kkraus14 commented Apr 6, 2023

Opened the PR to archive the thrust and cub feedstocks here: conda-forge/admin-requests#702

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants