-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cuda-cccl recipe #21953
Adding cuda-cccl recipe #21953
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cuda-cccl:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core @conda-forge/staged-recipes, could you please review? As noted in comment ( #21723 (comment) ), this is needed for |
cc @leofang |
Are we not splitting this up into Also, what is the strategy with regards to this and the public GitHub repos for these libraries? |
cc @robertmaynard (who was thinking about similar questions recently) |
From what I learned from Jake we should not do this. From the package maintenance viewpoint it's also more work. We should just retire {thrust,cub}-feedstocks going forward. |
Preferring closed source builds over open source builds is not something we want to ever encourage. |
I don't think that's what Leo is saying. Jake = @jrhemstad who leads the cccl team at NVIDIA. I believe he's saying that we shouldn't package Thrust, Cub, libcudf++, and anything else contained in cccl separately, presumably because there's plans that blur the boundaries between these libraries more than they're already blurred. That was my first question. The question about how we're handling using the open source repo(s) vs this prepackaged release from NVIDIA is a separate question. |
Correct. This hasn't been formally announced yet, but the Thrust/CUB/libcu++ repos will be merging into a single CCCL monorepo. Our vision for the future of these libraries is that they are parts of a unified whole and shouldn't be separated.
I'm ignorant when it comes to conda things. What are the pros/cons of pulling CCCL components from the prepackaged release vs. just pulling them from GitHub? GitHub is our source of truth, so I'd be more inclined to think the conda package should come from GH, but y'all know better than me. |
Thanks, Keith/Jake. Indeed, after NVIDIA/CCCL GH repo is set up we can definitely switch to use the open sourced tarballs, but right now we're not there yet, so what Alex has in this PR is just a temporary solution. I have made no comment on the choice of close vs open sources. Seems to me like a misinterpretation? |
Thanks for the clarification. Until NVIDIA/CCCL repo is setup, I think we should depend on thrust, cub conda packages in this package. Otherwise they will clobber each other. |
Clobbering is an important concern, but I think we can set up |
Would suggest that we not mess with how the compiler has been packaged by pulling in components not tested or used with it. This seems to introduce unnecessary reliability risk in a key component of the |
The challenge here is that in a normal system install, cccl lands in For us in a conda environment, both cccl and Thrust land in Has anyone inspected the cccl package to see if it's essentially just a metapackage of Thrust, Cub, and libcu++? |
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cuda-cccl-impl:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cuda-cccl-impl:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This looks good to go from my perspective. @adibbley @bdice @leofang @jakirkham @isuruf anything else that should be addressed before we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham Asked me to take a look here. My only comment is that it'd be nice to include a comment in each recipe explaining how it relates to the other recipes. This doesn't have to be detailed, but it will help us debug things in the future. Otherwise, I don't see anything obviously wrong with the recipes.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@adibbley Can you copy this package description to the cuda-cccl meta.yaml? #21953 (comment) Then let’s merge? 😉 |
I would suggest we merge as-is, and add the docs to conda-forge.github.io feedstock. Hiding this in a recipe comment is not very useful for conda-forge package maintainers. I can help this later. |
I already copied it. Can't hurt to have it in the docs as well once this is merged. |
Even better, thanks! |
Planning on merging EOD tomorrow if no comments |
Thanks all! 🙏 Let's follow up on anything else on the feedstocks |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).