Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-aarch64 / osx-arm64 builds #4

Merged
merged 16 commits into from
Oct 19, 2024

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #3.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #3

@Tobias-Fischer Tobias-Fischer changed the title MNT: rerender linux-aarch64 / osx-arm64 builds Oct 13, 2024
@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Oct 13, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11420727659.

conda-forge-webservices[bot] and others added 2 commits October 13, 2024 23:32
@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please rerender

@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please rerender

@Tobias-Fischer Tobias-Fischer marked this pull request as ready for review October 18, 2024 10:26
@Tobias-Fischer
Copy link
Contributor

@h-vetinari do you have any clue why CI is failing to checkout the code?

@h-vetinari
Copy link
Member

@h-vetinari do you have any clue why CI is failing to checkout the code?

No idea TBH, never seen that failure before...

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member

On aarch, you'll need something like conda-forge/faiss-split-feedstock@36fbef2 (until we solve conda-forge/conda-forge-pinning-feedstock#6283)

@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11415225410.

@Tobias-Fischer
Copy link
Contributor

Do we know which package contains libcuda.so.1? It cannot be loaded in the kaldi related tests on linux-64, something must have changed in the latest kaldi builds

@h-vetinari
Copy link
Member

Do we know which package contains libcuda.so.1?

That's one of the only libraries not packaged by conda-forge (due to licensing reasons AFAIU, even in the new CUDA 12+ stack). We'll need to skip the tests that require loading it. Presumably the relevant paths aren't being exercised on the kaldi feedstock.

The only alternative would be to switch to running on https://github.com/Quansight/open-gpu-server/, which has actual GPU hardware with the drivers available. That would be conceivable if too large a percentage of functionality of the package depends on loading libcuda, and we wouldn't want to skip all that.

CC @conda-forge/cuda-nvcc

@h-vetinari
Copy link
Member

I just had another thought why the tests passed before: it probably works fine if we use the CPU-only version of kaldi. That would make sense as a test-only restriction.

recipe/recipe.yaml Outdated Show resolved Hide resolved
@Tobias-Fischer
Copy link
Contributor

This is all green now @h-vetinari - please go ahead with your preferred way of pulling in kaldi and then I think we should be ready to merge

@h-vetinari h-vetinari merged commit d788f86 into conda-forge:main Oct 19, 2024
26 of 31 checks passed
thilinarmtb added a commit to thilinarmtb/staged-recipes that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
3 participants