-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torchvision v0.11.1 #31
torchvision v0.11.1 #31
Conversation
…nda-forge-pinning 2021.10.21.11.39.39
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
It might be that this needs pytorch 1.10 |
That's how I read the release tag as well (despite the version typo) - note also that 0.11.1 got released so fast after 0.11.0 that the bot even didn't "see it". |
@conda-forge-admin, please restart ci |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Ok so it seems I got the tests to get to completion on the CIs. However the tests seem to fail. It is a little suspicious since the tests that fail all seem to have the word "random" in them. Similar tests were failing on a local build. |
This comment has been minimized.
This comment has been minimized.
@conda-forge-admin please restart cis |
Three test classes can be found for the failing tests:
|
Could this have something to do with the fact that we're not building with ffmpeg support? |
that is likely it. how do we do this? |
On the "random" issue @hmaarrfk brought up, there was something in the new release about changing from scipy to torch to generate random samples, I suppose that this will be automatically implemented here, right? It's just another data point in the puzzle |
To be honest, I haven't checked. I'm pretty sure it's gonna be a build flag. See also #22 - I think there's an argument to be made for several output (well, depending on how difficult it is to build) for some reasonable set of
I overlooked Mark's comment at first - do you have a link to that?
If it's part of the torchvision code, then yes. If it's part of the pytorch build, it's too early to say (though I'm surprised this is being changed in a patch release). |
@h-vetinari here is the link, https://github.com/pytorch/vision/releases/tag/v0.11.0, midway through the page:
Issue link in quote: pytorch/vision#4256, which suggests the person changed the code itself, but I am not sure... |
fwiw: https://anaconda.org/fastchan/torchvision but not for the noarch |
unless the maintainer explicitly removed it. the recipe is included in the archive. are you able to do a diff with your eyes to see what we are missing? |
I will need to look deeply. That's why I wanted to do a crash course by making a recipe for torchaudio 😅 to be able to see this more intelligently/clearly I will find more details and report here. I will also try to see how the fastai people managed to build the latest versions (they seem to have a significantly laxer workflow in their repo) |
@conda-forge-admin please rerender |
@h-vetinari @hmaarrfk small update: I managed to build this locally and uploaded it here https://anaconda.org/ngam/torchvision -- I am still figuring out to how to translate that into this situation here. One "major" problem I faced: switching from the default pytorch==1.11.0 to pytorch==1.10.0 to get this to work. Otherwise, it will want to find the ARM version of pytorch==1.11.0 from their nightly channel and that was causing a lot of problems downstream for me. I have no idea if this will be relevant to your case. Will keep investigating... export 'CONDA_PYTORCH_CONSTRAINT=- pytorch==1.10.0'
export 'CONDA_PYTORCH_BUILD_CONSTRAINT=- pytorch==1.10.0' |
re av: @hmaarrfk i was looking at the open-ce repo (link: https://github.com/open-ce/torchvision-feedstock) and they had it and so I copied it, and well ... the results are in: went from 3 successful and 21 failing to 1 successful and 23 failing... so I guess that ain't it |
@hmaarrfk I am having a pretty hard time focusing on this to better identify the problem and play around (hence started a new pr to experiment) --- is there an easy way to suppress all the variants and build just a vanilla linux_64? If so, and you do have the time, please edit my other pr #33 or point me to it |
a6d82b2
to
7dd9450
Compare
ffmpeg needs a few extra libraries:
|
In either case, pytorch knows it crashes in osx:
|
@seemethere a while back you offered to help release pytorch. We've been at this feedstock for a while and I'm wondering if you could take a quick look at the failures. Your help would be greatly appreciated. Thank you! |
It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:
Checklist before merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
NEW: If you want these PRs to be merged automatically, make an issue with
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1369210201, please use this URL for debugging
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!