Add setuptools_scm build dep to fix dist-info version not being set #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/twine-feedstock/actions/runs/2464538637. |
|
@bollwyvl I confirmed this fixes the issue; looks like it's good to go now. |
|
thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Currently, as first discovered on pypa/twine#902 , the Twine conda package has an empty 0.0.0 version set in the core metadata (
.dist-info, as displayed by standard Python packaging tooling, e.g.pip list,twine --version,importlib_metadata, etc) instead of the correct version. This is due to a missingsetuptools_scmbuild-time dependency; I confirmed that adding such is all that is needed to fix this issue in conda-forge/lektor-feedstock#19 .Therefore, I've added the required versions of Setuptools and Setuptools_SCM as build-time dependencies (as specified upstream and in the current Setuptools_SCM docs), which should fix the problem (which I'll confirm checking the build output). Additionally, I've bumped the readme_renderer version to match the upstream requirement, which seemed to be an oversight.
I'll re-render once this PR passes tests and I confirm the correct
.dist-infoversion is displayed.