Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wmctrl CLI as dependency to Python wrapper #10

Merged
merged 5 commits into from
Jun 8, 2024
Merged

Add wmctrl CLI as dependency to Python wrapper #10

merged 5 commits into from
Jun 8, 2024

Conversation

ehfd
Copy link
Member

@ehfd ehfd commented Jun 2, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR adds the wmctrl (https://packages.debian.org/sid/wmctrl) CLI to this feedstock as a dependency so that this Python wrapper does not depend on the OS package manager.

@ehfd ehfd requested review from kynan and sodre as code owners June 2, 2024 06:43
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ehfd
Copy link
Member Author

ehfd commented Jun 2, 2024

@conda-forge-admin, please rerender

@ehfd
Copy link
Member Author

ehfd commented Jun 2, 2024

@ehfd
Copy link
Member Author

ehfd commented Jun 2, 2024

@kynan @sodre Please review.

@ehfd
Copy link
Member Author

ehfd commented Jun 2, 2024

@conda-forge-admin, please rerender

@ehfd
Copy link
Member Author

ehfd commented Jun 2, 2024

The Python wrapper depends on subprocess calls to wmctrl and xprop.

This PR covers the dependency for wmctrl.

xprop should be eventually covered by: conda-forge/staged-recipes#26241 but is generally bundled within the system.

@ehfd ehfd changed the title Add wmctrl CLI to dependency Add wmctrl CLI as dependency to Python wrapper Jun 2, 2024
@kynan kynan merged commit 70f45b4 into conda-forge:main Jun 8, 2024
4 checks passed
@ehfd ehfd deleted the patch-1 branch June 8, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants