-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bot-automerge] zstd v1.5.4 #67
[bot-automerge] zstd v1.5.4 #67
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
did they forget to inclue a fiel? |
Their cmake files use the |
it probably needs conda-forge/cmake-no-system-feedstock#11 |
@conda-forge-admin please restart cis |
Hi! This is the friendly conda-forge automerge bot! It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the |
it seems that a similar cmake patch has been used facebook/zstd@a0b09d0 |
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
ok, i give up. |
Due to the |
AFAICT the build script adds linking to zstd-feedstock/recipe/install.sh Lines 7 to 10 in d0d34ff
Though there is some interesting handling for CMake that comes after zstd-feedstock/recipe/install.sh Lines 14 to 22 in d0d34ff
It's worth noting upstream has made some changes to how linker flags are handled, which may be why the approach in the recipe is not currently working |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4141002832, please use this URL for debugging.