fix: version string #101
Merged
fix: version string #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, clean up meta.yaml to align better with conda-forge recipe
mattkram
force-pushed
the
fix/version-string
branch
from
c324618
to
3df1b6a
Compare
AlbertDeFusco
approved these changes
Apr 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 9 9
Lines 742 742
=======================================
Hits 717 717
Misses 25 25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Using a git archive doesn't seem to work, so I've reverted those changes: https://github.com/pypa/setuptools_scm#git-archives However, I have confirmed that we can publish the source tarball to pypi.org and then build the conda package from that. We may have an opportunity for some more work in the future to enable building the conda package from the released git tarball, but for now let's plan to build from pypi.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the dynamic loading of package version in the installed package.
We use
setuptools-scmto write the version to the filesrc/conda_project/_version.py. This file is not to be checked into git.We then dynamically import this file into the global
conda_project.__version__.This file will be generated both during
pip install -e ., as well as when generating the source distribution for PyPI viapython -m build.If there is any error importing the
_version.pyfile, the version number will be set to"unknown".A test has been added to the conda recipe to ensure that the version of the built package is correct.