-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cache zip and expanduser errors #110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
completed and tested in * CondaProject.__init__ * CondaProject.init * CondaProject.from_archive
a protocol-prepended url is something like file:///... https://... s3://... and sometimes these sources don't always support seeking. Using simplecache ensures that the whole archive is brought into local disk before extraction.
This was
linked to
issues
May 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 97.67% 97.68%
=======================================
Files 9 9
Lines 818 819 +1
=======================================
+ Hits 799 800 +1
Misses 19 19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
also drop string comparison in tests
it seems that I haven't found out how to tell pytests.raises that the block may raise "one of" a collection of exceptions.
to avoid a failure in conda-lock for repodata changes at repo.anaconda.com, restrict to installing from conda-forge
an error came out of cachecontrol through the vendored poetry in conda-lock. The conda-lock fix env var has been moved lower into the invocation of pytest.
for more information, see https://pre-commit.ci
mattkram
approved these changes
May 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #109 and #108.