Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache zip and expanduser errors #110

Merged
merged 10 commits into from
May 27, 2023
Merged

Conversation

AlbertDeFusco
Copy link
Contributor

This addresses #109 and #108.

completed and tested in
* CondaProject.__init__
* CondaProject.init
* CondaProject.from_archive
a protocol-prepended url is something like
file:///...
https://...
s3://...

and sometimes these sources don't always
support seeking. Using simplecache ensures
that the whole archive is brought into
local disk before extraction.
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #110 (308180a) into main (fd46c32) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   97.67%   97.68%           
=======================================
  Files           9        9           
  Lines         818      819    +1     
=======================================
+ Hits          799      800    +1     
  Misses         19       19           
Impacted Files Coverage Δ
src/conda_project/project.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AlbertDeFusco and others added 7 commits May 19, 2023 17:12
also drop string comparison in tests
it seems that I haven't found out how to tell
pytests.raises that the block may raise "one of"
a collection of exceptions.
to avoid a failure in conda-lock for repodata
changes at repo.anaconda.com, restrict
to installing from conda-forge
an error came out of cachecontrol
through the vendored poetry in conda-lock.
The conda-lock fix env var has been moved
lower into the invocation of pytest.
Copy link
Contributor

@mattkram mattkram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@AlbertDeFusco AlbertDeFusco merged commit db904e1 into main May 27, 2023
@AlbertDeFusco AlbertDeFusco deleted the fix/cache-zip-expanduser branch May 27, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User directory expansion not working Cannot open archive from a stream
2 participants