-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newer conda-lock drops optional attribute #129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 97.69% 97.69%
=======================================
Files 9 9
Lines 826 826
=======================================
Hits 807 807
Misses 19 19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any chance of a string (p.category) coming back with whitespace or is that well-controlled?
Good question. I'll have to check |
conda-lock will throw an error during
|
Okay so my guess is they've got an enum of some sort? I should look. As long as we're confident that non-optional packages are marked as "main" I say let's merge it. |
There is an edge case in conda-lock itself that would be brought up to conda-project. If you provide a category that is not called dependencies:
- python=3.10
channels: [defaults]
category: not-main The env will lock but
I think in a separate issue maybe we can address some warnings if no |
No description provided.