Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates MockWriter class in favor of pyfakefs #120

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

schuylermartin45
Copy link
Collaborator

@schuylermartin45 schuylermartin45 commented Sep 13, 2024

This work is no longer necessary now that we are using pyfakefs. Best delete it now before it is used and we have two competing solutions to the same problem.

@schuylermartin45 schuylermartin45 requested a review from a team as a code owner September 13, 2024 20:35
@schuylermartin45 schuylermartin45 enabled auto-merge (squash) September 13, 2024 20:36
Copy link
Contributor

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid removal.

@schuylermartin45 schuylermartin45 merged commit 679a9a8 into main Sep 13, 2024
12 checks passed
@schuylermartin45 schuylermartin45 deleted the deprecate_mock_writer branch September 13, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants