Minor CI Improvements #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…All other pre-commit stages do not have this behavior as they will spam the logs.
Closed
beeankha
approved these changes
Nov 8, 2024
This was
unlinked from
issues
Nov 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a handful of minor CI improvements:
pytestcoverage logs in the pre-commit CI test to show current code coverage. This is done in such a way that anypre-commitcommand should show the test coverage report.Makefile3.11from the test matrix, as3.11is used by thepre-commitjob. In other words, we are now saving some redudant computation.This also suppresses some new warnings I found while working on this issue. Issues #236 and #237 have been created as a result.
I ended up NOT adding
python 3.13tests to the test matrix as it does not appear to be ready yet.