-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
260 Parallelize multiple source fetch requests #264
260 Parallelize multiple source fetch requests #264
Conversation
…ipt can be exited gracefully on a network failure
The
cause the slow down. Each of these cases takes ~30 seconds to complete. They both have multiple sources but they are fully mocked. |
The slow down goes away if I remove |
Upgrading to |
Reverted back to the older version, definitely transient. I just didn't run enough instances to see a shorter runtime. |
Can't reproduce this slow down in a real (non-test) environment. Will spin-off this issue to another ticket, as it does not affect users. |
…instead of saving it to a file
We now use futures to download multiple source files concurrently.
Also introduces a
--dry-run
mode that dumps the recipe file to STDOUT instead of overwriting the recipe file.Putting this PR up as a Draft until I can figure out why some of theThat issue is now tracked in #265 as it appears to have no known user impact and is tied to the test environment.bump_recipe_cli
tests are significantly slower after this change (causing the tests to take 4 seconds to 35 seconds).