-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs are now automatically aggregated into the GHA Summary #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use this oppurtuntiy to switch to setup-miniconda from a mixed setup-python (which installs python.org's Python) and relying on GitHub Actions' conda.
description: "Version of python to use in the conda environment." | ||
required: false | ||
default: "3.11" | ||
|
||
runs: | ||
using: "composite" | ||
steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't use setup-python, but instead of setup-miniconda to make sure we have a consistent Python build in use. In fact, you'll likely be able to get rid of this setup-env workflow completely since setup-miniconda implements the steps except for the pip install -e .
call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I swapped setup-python for setup-miniconda. I was hopping to get some more of the boiler-plate out of the way, but my experiments did not pan out. The point of this action is to reduce duplicated start-up work across all the workflows, so I'm okay keeping it. It makes it easier if I have to change the setup steps in the future.
…on file. Maybe this will work for the context of the action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Walked through this CI infrastructure work with @schuylermartin45 , LGTM!
Automates the aggregation of integration test statistics from the various integration tests that run as part of this.
This process only runs if all integration tests pass (which are required to pass to merge a PR).
Also:
ci.yaml
file into two files, one for "commit checks" and one for integration testsTo view the summary of results, go to this repo on GitHub,
Actions
->Workflow Run
(instance in the list) ->Summary
.