Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs are now automatically aggregated into the GHA Summary #37

Merged
merged 18 commits into from
Apr 26, 2024

Conversation

schuylermartin45
Copy link
Collaborator

@schuylermartin45 schuylermartin45 commented Apr 22, 2024

Automates the aggregation of integration test statistics from the various integration tests that run as part of this.
This process only runs if all integration tests pass (which are required to pass to merge a PR).

Also:

  • Splits-up the ci.yaml file into two files, one for "commit checks" and one for integration tests
  • Fixes some warning messages
  • Bumps the latest integration test thresholds.

To view the summary of results, go to this repo on GitHub, Actions -> Workflow Run (instance in the list) -> Summary.

@schuylermartin45 schuylermartin45 marked this pull request as ready for review April 22, 2024 19:21
@schuylermartin45 schuylermartin45 requested a review from a team as a code owner April 22, 2024 19:21
@schuylermartin45 schuylermartin45 marked this pull request as draft April 22, 2024 19:23
@schuylermartin45 schuylermartin45 changed the title Log aggregation comment bot Logs are now automatically aggregated into the GHA Summary Apr 23, 2024
@schuylermartin45 schuylermartin45 marked this pull request as ready for review April 23, 2024 20:30
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use this oppurtuntiy to switch to setup-miniconda from a mixed setup-python (which installs python.org's Python) and relying on GitHub Actions' conda.

description: "Version of python to use in the conda environment."
required: false
default: "3.11"

runs:
using: "composite"
steps:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't use setup-python, but instead of setup-miniconda to make sure we have a consistent Python build in use. In fact, you'll likely be able to get rid of this setup-env workflow completely since setup-miniconda implements the steps except for the pip install -e . call.

Copy link
Collaborator Author

@schuylermartin45 schuylermartin45 Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swapped setup-python for setup-miniconda. I was hopping to get some more of the boiler-plate out of the way, but my experiments did not pan out. The point of this action is to reduce duplicated start-up work across all the workflows, so I'm okay keeping it. It makes it easier if I have to change the setup steps in the future.

@schuylermartin45 schuylermartin45 requested a review from jezdez April 24, 2024 15:46
Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through this CI infrastructure work with @schuylermartin45 , LGTM!

@schuylermartin45 schuylermartin45 merged commit b1adc60 into main Apr 26, 2024
11 checks passed
@schuylermartin45 schuylermartin45 deleted the smartin_aggregate_integration_bot branch April 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants