Multiline summary fix issue 44 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test passes without warnings
- The conversion tooling can now upgrade _most_ situations where `script_env` is present. - We cannot easily upgrade scenarios where an environment variable is specified with a value with a selector. That will require manual intervention for now
…sting to ensure failure is handled correctly
…r into smartin_script_env_support
…ey for the sha256 field
…h a period mark to using the pipe functions supported by rattler-build
…r into smartin_preprocess_replace_dot_with_bar_functions
… smartin_multiline_summary_fix_issue_44
…r into smartin_multiline_summary_fix_issue_44
wolfv
approved these changes
Jun 7, 2024
beeankha
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44 . A number of packages in the integration testing data (namely R-packages) contain multiline strings in their summaries that are unmarked (i.e. they do not use the
|,>or other variants indicating how multiline strings are represented).The ideal fix would be to handle this at parse-time. But that is a relatively big ask. So for the short-term, here is a small fix that makes a pretty big impact on our compatibility with R-packages.
Arguably this transforms these problematic recipes to be "compliant" and use the much more commonly used
|-multiline YAML option used by recipes in AnacondaRecipes and conda-forge.