Add log link next to status message

[gabalafou]

Fixes #244. (But note that in the interest of time, I did not follow the design mocks exactly.)

Description

This pull request:

• Renders a log link in the <EnvBuilds> component if the currently selected build status is "Failed"
• Adds two tests
• Adds story to Storybook

Pull request checklist

• Did you test this change locally?
• Did you update the documentation (if required)?
• Did you add/update relevant tests for this change (if required)?

[gabalafou]

Do the docs need to be updated for a change this small?

[gabalafou]

Done self-reviewing

[peytondmurray]

Out of curiosity, how come this is needed? Are there cases where currentBuild is undefined? Looking through buildMapper it seems like the currentBuildId should always have a corresponding item in builds.

[gabalafou]

Yeah... that's a good question. I don't know... Pagination maybe?

It doesn't help that the variable currentBuild does not actually correspond the currentBuildId build, see line 28 above:

  const currentBuild = envBuilds.find(build => build.id === selectedBuildId);

So maybe there's some way you can select a build id that isn't in the builds for that environment?

[peytondmurray]

I don't have the context to know whether an additional refactor here is appropriate, but you might. If you feel like this could be cleaner, please make an issue for it. In the meantime, let's get this merged.

[gabalafou]

Thanks @peytondmurray!

[gabalafou]

Yeah... that's a good question. I don't know... Pagination maybe?

It doesn't help that the variable currentBuild does not actually correspond the currentBuildId build, see line 28 above:

  const currentBuild = envBuilds.find(build => build.id === selectedBuildId);

So maybe there's some way you can select a build id that isn't in the builds for that environment?

[gabalafou]

I do not know why the Playwright test is failing for this PR

[gabalafou]

OK, test passing now, this just needs to be approved

[peytondmurray]

Approved, see note though about filing an issue if a refactor of EnvBuilds.tsx is appropriate. The fact that it's confusing for both of us probably means we should track an issue even if we don't work on it right away, but I'll defer to your judgment about this.