Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue and pull request templates #521

Merged
merged 7 commits into from
Aug 9, 2023

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Aug 2, 2023

This PR is part of #514

This PR,

  • Update issue template for bug reports
  • Update issue template for feature requests
  • Adds an issue template for general issues
  • Adds a pull request template

@steff456 steff456 added project: JATIC Work item needed for the JATIC project area: user experience 👩🏻‍💻 Items impacting the end-user experience area: community 🌱 labels Aug 2, 2023
@steff456 steff456 added this to the 🚀 JATIC - Q1 milestone Aug 2, 2023
@steff456 steff456 requested a review from trallard August 2, 2023 23:28
@steff456 steff456 self-assigned this Aug 2, 2023
@steff456 steff456 changed the title Update issue templates Update issue and pull request templates Aug 3, 2023
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @trallard do you have any feedback on these templates I'm assuming that these templates are modeled after other issue templates we've used.

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steff456 Thank you for this PR! I've added a couple of small suggestions, but it looks great overall. I'll approve, so you can feel-free to merge when ready. :)

Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @steff456, I have requested some changes, also we need to add a config.yml file to direct people to the templates and the documentation. And to disallow blank issues.

.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature-request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/general-issue.yml Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@steff456
Copy link
Contributor Author

steff456 commented Aug 7, 2023

@trallard there's already a config.yml under .github/ISSUE_TEMPLATE/ folder that disallows blank issues. Let me know if there's anything extra this PR needs!

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that config only disallows the blank issue.
Can you also link to the conda-store docs from there and add the templates?

If you need a reference see the Nebari config

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed some changes directly and can merge as-is I do not want this to linger any more

@trallard trallard merged commit f0a541b into conda-incubator:main Aug 9, 2023
7 of 8 checks passed
@steff456 steff456 deleted the update-issue-templates branch August 9, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: community 🌱 area: user experience 👩🏻‍💻 Items impacting the end-user experience project: JATIC Work item needed for the JATIC project status: merge ready 🚀
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

5 participants