-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update issue and pull request templates #521
Update issue and pull request templates #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @trallard do you have any feedback on these templates I'm assuming that these templates are modeled after other issue templates we've used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steff456 Thank you for this PR! I've added a couple of small suggestions, but it looks great overall. I'll approve, so you can feel-free to merge when ready. :)
Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @steff456, I have requested some changes, also we need to add a config.yml
file to direct people to the templates and the documentation. And to disallow blank issues.
@trallard there's already a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that config only disallows the blank issue.
Can you also link to the conda-store docs from there and add the templates?
If you need a reference see the Nebari config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed some changes directly and can merge as-is I do not want this to linger any more
This PR is part of #514
This PR,