Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete subdomain keys on logout #541

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Delete subdomain keys on logout #541

merged 2 commits into from
Aug 18, 2023

Conversation

anirrudh
Copy link
Contributor

@anirrudh anirrudh commented Aug 17, 2023 •
edited
Loading

Fixes #512

Description

Deletes cookies properly on logout. Code has been formatted with Black.

This pull request:

  • a
  • b
  • c

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentaion (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@anirrudh anirrudh requested a review from costrouc August 17, 2023 19:57
costrouc
costrouc suggested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave the wrong advice in the issue. Need to set the domain to the traitlets variable.

@costrouc costrouc merged commit 92246cd into conda-incubator:main Aug 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costrouc costrouc costrouc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logout method does not clear subdomain cookie
2 participants
@anirrudh @costrouc