Add a macOS worker to the CI #550

asmeurer · 2023-08-25T21:27:53Z

Description

This is built on #549 but I've made in a separate PR because I'm not sure if there will be other issues here and I don't want to block that PR on this (but at the same time, tests won't pass on Mac without the changes from that PR).

See #513 and #507

Pull request checklist

Did you test this change locally?
Did you update the documentaion (if required)?
Did you add/update relevant tests for this change (if required)?

Additional information

asmeurer · 2023-08-25T21:50:27Z

The setup-miniconda stage failed with

Updating 'conda-store-server-dev' env from conda env update...
  /usr/local/miniconda/condabin/mamba env update --name conda-store-server-dev --file conda-store-server/environment-dev.yaml
  Warning: Traceback (most recent call last):
    File "/usr/local/miniconda/condabin/mamba", line 7, in <module>
  
  Traceback (most recent call last):
    File "/usr/local/miniconda/condabin/mamba", line 7, in <module>
  Warning:     from mamba.mamba import main
    File "/usr/local/miniconda/lib/python3.11/site-packages/mamba/mamba.py", line 49, in <module>
      import libmambapy as api
  
      from mamba.mamba import main
    File "/usr/local/miniconda/lib/python3.11/site-packages/mamba/mamba.py", line 49, in <module>
      import libmambapy as api
  Warning:   File "/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/__init__.py", line 7, in <module>
  
    File "/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/__init__.py", line 7, in <module>
  Warning:     raise e
    File "/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/__init__.py", line 4, in <module>
  
      raise e
    File "/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/__init__.py", line 4, in <module>
  Warning:     from libmambapy.bindings import *  # noqa: F401,F403
  
      from libmambapy.bindings import *  # noqa: F401,F403
  Warning:     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ImportError: dlopen(/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/bindings.cpython-311-darwin.so, 0x0002): Library not loaded: '@rpath/libarchive.13.dylib'
    Referenced from: '/usr/local/miniconda/lib/libmamba.2.0.0.dylib'
    Reason: tried: '/usr/local/miniconda/lib/libarchive.13.dylib' (no such file), '/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/../../../libarchive.13.dylib' (no such file), '/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/../../../libarchive.13.dylib' (no such file), '/usr/local/miniconda/bin/../lib/libarchive.13.dylib' (no such file), '/usr/local/miniconda/bin/../lib/libarchive.13.dylib' (no such file), '/usr/local/lib/libarchive.13.dylib' (no such file), '/usr/lib/libarchive.13.dylib' (no such file)
  
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ImportError: dlopen(/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/bindings.cpython-311-darwin.so, 0x0002): Library not loaded: '@rpath/libarchive.13.dylib'
    Referenced from: '/usr/local/miniconda/lib/libmamba.2.0.0.dylib'
    Reason: tried: '/usr/local/miniconda/lib/libarchive.13.dylib' (no such file), '/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/../../../libarchive.13.dylib' (no such file), '/usr/local/miniconda/lib/python3.11/site-packages/libmambapy/../../../libarchive.13.dylib' (no such file), '/usr/local/miniconda/bin/../lib/libarchive.13.dylib' (no such file), '/usr/local/miniconda/bin/../lib/libarchive.13.dylib' (no such file), '/usr/local/lib/libarchive.13.dylib' (no such file), '/usr/lib/libarchive.13.dylib' (no such file)

costrouc · 2023-08-30T02:08:08Z

🤞 looking forward to this one!

This is built on conda-incubator#549 but I've made in a separate PR because I'm not sure if there will be other issues here and I don't want to block that PR on this (but at the same time, tests won't pass on Mac without the changes from that PR). See conda-incubator#513 and conda-incubator#507

trallard · 2023-09-11T14:37:35Z

@asmeurer is there anything else that needs doing?

asmeurer · 2023-09-11T19:21:01Z

The CI is failing in the initial setup stage of setup-miniconda. I'm not sure why. Since the error occurs in the setup stage, it seems like it would be an issue with setup-miniconda itself. And I haven't changed any part of that in the CI config, all I did was add macos as a platform to the matrix.

It would help if someone more familiar with that could take a look (like Jaime, or if he is available, Gonzalo since he seems to be the main maintainer of setup-miniconda).

I can't really do much until the CI works, but I expect that things ought to pass once they do, since the tests working for me locally on my Mac.

netlify · 2023-10-06T21:39:42Z

✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name	Link
🔨 Latest commit	`821da8f`
🔍 Latest deploy log	https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6520b98f9367b50008a08233

This reverts commit 031574a.

Revert "Revert "Try using mamba on macos again"" This reverts commit 6cf2877.

Revert "Go back to using mamba but with the correct syntax this time" This reverts commit b82c0c8.

asmeurer · 2023-10-07T01:49:00Z

This is working now. I believe the test failure is the one I noted on Slack (I'll open an issue later), which is related to the paths being too long.

asmeurer · 2023-10-07T01:50:15Z

Oh actually the one I posted on Slack is different. I get that locally but it doesn't happen on CI. The issue here is I just need to disable Docker from being tested on Mac.

asmeurer · 2023-10-07T08:02:48Z

.github/workflows/tests.yaml

@@ -26,14 +25,23 @@ jobs:
      - name: "Checkout Repository"
        uses: actions/checkout@v4

-      - name: Set up Python
+      - name: Set up Python (Linux)
+        if: matrix.os == 'ubuntu-latest'
        uses: conda-incubator/setup-miniconda@v2
        with:
          mamba-version: "*"


@trallard is removing this what you had in mind? It seems to work. The install on CI is a few minutes slower but I'm not sure if it's significant enough to worry about.

yep, need to use mamba only

I think this is doing the opposite, using conda only and not using mamba at all. But like I said, it's not that much slower.

trallard

This looks good and CI is passing now so will merge

pavithraes added area: testing ✅ status: in progress 🏗 labels Aug 30, 2023

asmeurer force-pushed the macos-ci branch from 5c4fadc to b45e08e Compare August 30, 2023 21:14

trallard assigned asmeurer Sep 26, 2023

asmeurer mentioned this pull request Oct 6, 2023

CI - Run tests on macOS #604

Closed

Trigger build

4badce3

asmeurer added 9 commits October 6, 2023 15:42

Try not using mamba to fix macos CI

134cc42

Merge branch 'main' into macos-ci

792cd95

Add a separate macos environment file without conda-docker

56d7652

Use the macos environment file for macos on CI

f260e12

Try using mamba on macos again

031574a

Revert "Try using mamba on macos again"

6cf2877

This reverts commit 031574a.

Install mamba in the dev environment

c954b8e

Go back to using mamba but with the correct syntax this time

b82c0c8

Revert "Revert "Try using mamba on macos again"" This reverts commit 6cf2877.

Fix CI

0173e16

Revert "Go back to using mamba but with the correct syntax this time" This reverts commit b82c0c8.

Only test docker on Linux

821da8f

asmeurer added the needs: review 👀 label Oct 7, 2023

asmeurer commented Oct 7, 2023

View reviewed changes

trallard approved these changes Oct 9, 2023

View reviewed changes

trallard merged commit 0f26920 into conda-incubator:main Oct 9, 2023
12 checks passed

jaimergp mentioned this pull request Nov 2, 2023

META - Support for Windows and MacOS (local) #507

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a macOS worker to the CI #550

Add a macOS worker to the CI #550

asmeurer commented Aug 25, 2023

asmeurer commented Aug 25, 2023

costrouc commented Aug 30, 2023

trallard commented Sep 11, 2023

asmeurer commented Sep 11, 2023

netlify bot commented Oct 6, 2023 •

edited

Loading

asmeurer commented Oct 7, 2023

asmeurer commented Oct 7, 2023

asmeurer Oct 7, 2023

trallard Oct 9, 2023

asmeurer Oct 9, 2023

trallard left a comment

Add a macOS worker to the CI #550

Add a macOS worker to the CI #550

Conversation

asmeurer commented Aug 25, 2023

Description

Pull request checklist

Additional information

asmeurer commented Aug 25, 2023

costrouc commented Aug 30, 2023

trallard commented Sep 11, 2023

asmeurer commented Sep 11, 2023

netlify bot commented Oct 6, 2023 • edited Loading

✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

asmeurer commented Oct 7, 2023

asmeurer commented Oct 7, 2023

asmeurer Oct 7, 2023

Choose a reason for hiding this comment

trallard Oct 9, 2023

Choose a reason for hiding this comment

asmeurer Oct 9, 2023

Choose a reason for hiding this comment

trallard left a comment

Choose a reason for hiding this comment

netlify bot commented Oct 6, 2023 •

edited

Loading