Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conda-store-server test port configurable #571

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Sep 12, 2023

Related to #570

I have to use a non-default port (not 5000) on my mac for development. This PR allows the playwright tests to run on any port instead of hard-coding the port.

Description

This pull request:

  • allows the playwright tests to run on a configurable port via env var
  • creates a pytest fixture for the port
  • updates the playwright test to use the new fixture

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@kcpevey kcpevey added the area: documentation 📖 Improvements or additions to documentation label Sep 12, 2023
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d ready!

Name Link
🔨 Latest commit f8bec15
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6500ded9321a0300086c426b
😎 Deploy Preview https://deploy-preview-571--kaleidoscopic-dango-0cf31d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trallard trallard merged commit 274c759 into main Sep 15, 2023
12 checks passed
@trallard trallard deleted the configurable_port branch September 15, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants