Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace port 5000 with port 8080 #642

Merged
merged 1 commit into from
Oct 27, 2023
Merged

replace port 5000 with port 8080 #642

merged 1 commit into from
Oct 27, 2023

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Oct 27, 2023

Fixes #618 .

Description

Replaces port 5000 with port 8080 as the default port to run on. Port 8080 is not a privileged port, but is an alternate port for HTTP. Port 5000 is in use on some Mac computers which causes conflicts.

This pull request:

  • Replaces port 5000 with port 8080 as default port.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 90f22ee
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/653c08a0d2bd3d0008e1a18c

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is LONG overdue 😄. The 5000 port is used for airpods and I remember first encountering this with @pierrotsmnrd 's laptop.

@costrouc
Copy link
Member

costrouc commented Oct 27, 2023

This may cause a breaking change in the client's etc. assuming port 5000 by default but I'm unsure. Most clients use 80/443 with a proper installation. But I know a lot of the development assumptions in clients use 5000.

@dcmcand dcmcand merged commit 0760fa2 into main Oct 27, 2023
19 checks passed
@dcmcand dcmcand deleted the dmcandrew-update-port branch October 27, 2023 20:09
@kcpevey
Copy link
Contributor

kcpevey commented Oct 27, 2023

This may cause a breaking change in the client's etc. assuming port 5000 by default but I'm unsure.

We'll need to make a note in the release notes.

@nkaretnikov
Copy link
Contributor

nkaretnikov commented Oct 30, 2023

Have you tested this with conda-store-ui? For me, this breaks the login process (when you click on the Login button) when using conda-store-ui. Because the UI assumes port 5000 for conda-store. I'll open an issue on the UI side.

Also, port 8080 is what conda-store-ui has been using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - port 5000 is a problem on MacOS
4 participants