Add user journey test #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kaleidoscopic-dango-0cf31d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nkaretnikov
suggested changes
Feb 19, 2024
There was a problem hiding this comment.
@dcmcand Thanks for adding this! I think this PR needs some changes, I've left some comments for your consideration.
nkaretnikov
added
status: in progress 🏗
needs: review 👀
and removed
status: needs changes 🧱
labels
nkaretnikov
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
@dcmcand LGTM. I've left some comments, but those are non-blockers. Up to you whether to fix those before merging.
nkaretnikov
added
status: merge ready 🚀
and removed
status: in progress 🏗
needs: review 👀
labels
Co-authored-by: Nikita Karetnikov <nkaretnikov@quansight.com>
Co-authored-by: Nikita Karetnikov <nkaretnikov@quansight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668
Fixes #662
Description
Adds an initial user journey test. This test follows a normal user workflow (using only api calls) to ensure that user workflows are not broken. It also begins to build up a library of actions that can be used to compose future user journey tests.
This test has been tested locally, in CI and against https://nebari.quansight.dev and it worked in all cases.
Pull request checklist
Additional information
How to test
docker compose upconda-store-serverfoldercd conda-store-serverpytest -m user_journey