Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Document setting environment variable #765

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Feb 6, 2024

Fixes #759

Description

This pull request:

  • Adds a note about setting environment variable
  • Minor misc clean-up

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

Merge after the conda-store-ui feature is merged.

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit fb29e0f
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65e0c344ba66c70008591345

Copy link
Contributor

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavithraes Thanks for documenting this! I've left some comments for your consideration.

Note: this feature is already in conda-store-server, but it's still in review in conda-store-ui. So I'm going to mark this PR as blocked until that one lands, see: conda-incubator/conda-store-ui#354.

docusaurus-docs/conda-store-ui/tutorials/create-envs.md Outdated Show resolved Hide resolved
@@ -47,11 +47,9 @@ conda-store-server --standalone

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move changes in this file into a separate PR. To me, these look unrelated to the environment variables change, which means they can be merged separately (and likely much faster as well).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review :)

I did mention in the PR description that it includes some minor, miscellaneous clean-up, so I thought this would be alright.

However, I do agree we should aim for cleaner+specific PRs. I'll revert these updates.

docusaurus-docs/conda-store-ui/tutorials/create-envs.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store-ui/tutorials/create-envs.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store-ui/tutorials/create-envs.md Outdated Show resolved Hide resolved
@pavithraes
Copy link
Member Author

@nkaretnikov Thanks for your review, I have addressed all your comments. :)

Please take another look and approve it when you get a chance. Of course, even after approval, we'll only merge after https://github.com/conda-incubator/conda-store-ui/pull/354 is merged.

Copy link
Contributor

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavithraes Thanks, LGTM! I've left two comments, which would be nice to fix, but those are not blockers. OK to merge this after the companion UI PR lands: conda-incubator/conda-store-ui#354

docusaurus-docs/conda-store-ui/tutorials/create-envs.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store-ui/tutorials/create-envs.md Outdated Show resolved Hide resolved
Co-authored-by: Nikita Karetnikov <nikita@karetnikov.org>
@trallard trallard merged commit e652f03 into conda-incubator:main Feb 29, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation status: merge ready 🚀
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Document support for variables in environment spec
3 participants