Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conda recipe with verification workflow #793

Merged
merged 16 commits into from
Apr 2, 2024
Merged

Add conda recipe with verification workflow #793

merged 16 commits into from
Apr 2, 2024

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Mar 23, 2024 •
edited
Loading

(Part of a conversation with @trallard)

Description

This pull request:

  • Adds recipe/ with a couple minor fixes (to be contributed to conda-forge)
  • Adds a Release workflow step depending on a new action https://github.com/jaimergp/conda-build-action
  • Together this all ensures the conda dependencies are in sync with the Python ones

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

This is a CI change, so it's a matter of making the CI pass. That said, one can run conda build recipe in different OSs to get a feeling.

@netlify Netlify
Copy link

netlify bot commented Mar 23, 2024 •
edited
Loading

✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 7b99a2c
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/66031668e4d42b0008c2fba4

@jaimergp jaimergp marked this pull request as ready for review March 25, 2024 08:58
trallard
trallard reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a number of changes ad other missing deps

.github/workflows/conda.yml Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
@jaimergp @trallard
Apply suggestions from code review
40f8d9a 
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
@trallard @jaimergp
Update recipe/meta.yaml
7e1f5e7 
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@trallard @jaimergp
Apply suggestions from code review
7b99a2c 
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
trallard
trallard approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. If CI is happy 😬 we can merge

@trallard trallard merged commit 8088f74 into main Apr 2, 2024
23 of 25 checks passed
@trallard trallard deleted the add-recipe branch April 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallard trallard trallard approved these changes

Assignees
No one assigned
Labels
area: CI 👷🏽‍♀️ area: dependencies 📦 Issues related to conda-store dependencies status: merge ready 🚀 type: enhancement 💅🏼
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaimergp @trallard