Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no documentation available for CONDA_ENV #4492

Closed
jugmac00 opened this issue May 31, 2022 · 5 comments · Fixed by #4957
Closed

no documentation available for CONDA_ENV #4492

jugmac00 opened this issue May 31, 2022 · 5 comments · Fixed by #4957
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward locked [bot] locked due to inactivity source::community catch-all for issues filed by community members stale [bot] marked as stale due to inactivity type::documentation request for improved documentation

Comments

@jugmac00
Copy link
Contributor

jugmac00 commented May 31, 2022

CONDA_ENV is used to set the name for a conda virtual environment a la

    $ CONDA_ENV=conda-build make setup
    $ conda activate conda-build
    (conda-build) $ make test

The environment variable is not documented.

The only two occurrences are in

$ CONDA_ENV=conda-build make setup

and
https://github.com/conda/conda/blob/0adcd595c97d0c4e3b2645aebd50ded8d771d5eb/CHANGELOG.md?plain=1#L2487

@kenodegard
Copy link
Contributor

@jugmac00 looks like it's supposed to be ENV_NAME, not CONDA_ENV

ENV_NAME ?= conda-build

@kenodegard kenodegard transferred this issue from conda/conda-docs May 31, 2022
@kenodegard kenodegard added type::documentation request for improved documentation backlog issue has been triaged but has not been earmarked for any upcoming release good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward source::community catch-all for issues filed by community members labels May 31, 2022
@jugmac00
Copy link
Contributor Author

Thanks! This certainly explains why I only found two mentions of CONDA_ENV :-D

@jugmac00
Copy link
Contributor Author

jugmac00 commented Jun 2, 2022

@kenodegard You marked this issue as "good-first-issue".

What does it take to fix this issue?

Create two PRs to change the occurrences from CONDA_ENV to ENV_NAME?

@kenodegard
Copy link
Contributor

@jugmac00 It should be sufficient to only modify the CONTRIBUTING.md in conda-build, the occurrence of CONDA_ENV in conda's CHANGELOG.md is valid and refers to an older unrelated feature.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jul 3, 2023
jugmac00 added a commit to jugmac00/conda-build that referenced this issue Aug 5, 2023
You need to use `ENV_NAME` instead of `CONDA_ENV` for setting up conda build.

Fixes conda#4492
jugmac00 added a commit to jugmac00/conda-build that referenced this issue Aug 5, 2023
You need to use `ENV_NAME` instead of `CONDA_ENV` for setting up conda build.

Fixes conda#4492
@github-project-automation github-project-automation bot moved this to 🏁 Done in 🧭 Planning Aug 18, 2023
beeankha pushed a commit that referenced this issue Aug 18, 2023
You need to use `ENV_NAME` instead of `CONDA_ENV` for setting up conda build.

Fixes #4492
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward locked [bot] locked due to inactivity source::community catch-all for issues filed by community members stale [bot] marked as stale due to inactivity type::documentation request for improved documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants