Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conda-build CLI overrides condarc's zstd_compression_level with the default value #4649

Closed
2 tasks done
mbargull opened this issue Nov 24, 2022 · 0 comments · Fixed by #4650
Closed
2 tasks done

conda-build CLI overrides condarc's zstd_compression_level with the default value #4649

mbargull opened this issue Nov 24, 2022 · 0 comments · Fixed by #4650
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward locked [bot] locked due to inactivity severity::1 blocker; broken functionality with no workaround source::community catch-all for issues filed by community members tag::performance related to degraded performance type::bug describes erroneous operation, use severity::* to classify the type
Milestone
3.23.2

Comments

@mbargull
Copy link
Member

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

The conda-build command defines a default value for --zstd-compression-level (conda_build.config.zstd_compression_level_default=22) without querying the Conda config for the conda_build.zstd_compression_level key.
Since parameters given by the CLI take precedence over those from .condarc, a zstd_compression_level set in the latter is always overridden by the default value when conda-build ... is invoked.

Conda Info

active environment : base
    active env location : /opt/conda/envs/conda-build
            shell level : 2
       user config file : /home/conda/.condarc
 populated config files : /home/conda/.condarc
          conda version : 22.9.0
    conda-build version : 3.23.1
         python version : 3.11.0.final.0
       virtual packages : __linux=5.10.148=0
                          __glibc=2.17=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /opt/conda/envs/conda-build  (writable)
      conda av data dir : /opt/conda/envs/conda-build/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/linux-64
                          https://conda.anaconda.org/conda-forge/noarch
                          https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /opt/conda/envs/conda-build/pkgs
                          /home/conda/.conda/pkgs
       envs directories : /opt/conda/envs/conda-build/envs
                          /home/conda/.conda/envs
               platform : linux-64
             user-agent : conda/22.9.0 requests/2.28.1 CPython/3.11.0 Linux/5.10.148-1-MANJARO centos/7.9.2009 glibc/2.17
                UID:GID : 9001:9001
             netrc file : None
           offline mode : False

Conda Config

==> /home/conda/.condarc <==
channel_priority: strict
channels:
  - conda-forge
  - defaults
show_channel_urls: True

Conda list

# packages in environment at /opt/conda/envs/conda-build:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                 conda_forge    conda-forge
_openmp_mutex             4.5                       2_gnu    conda-forge
beautifulsoup4            4.11.1             pyha770c72_0    conda-forge
brotlipy                  0.7.0           py311hd4cff14_1005    conda-forge
bzip2                     1.0.8                h7f98852_4    conda-forge
ca-certificates           2022.9.24            ha878542_0    conda-forge
certifi                   2022.9.24          pyhd8ed1ab_0    conda-forge
cffi                      1.15.1          py311h409f033_2    conda-forge
chardet                   5.0.0           py311h38be061_1    conda-forge
charset-normalizer        2.1.1              pyhd8ed1ab_0    conda-forge
colorama                  0.4.6              pyhd8ed1ab_0    conda-forge
conda                     22.9.0          py311h38be061_2    conda-forge
conda-build               3.23.1          py311h38be061_0    conda-forge
conda-package-handling    1.9.0           py311hd4cff14_1    conda-forge
cryptography              38.0.3          py311h42a1071_0    conda-forge
filelock                  3.8.0              pyhd8ed1ab_0    conda-forge
glob2                     0.7                        py_0    conda-forge
icu                       70.1                 h27087fc_0    conda-forge
idna                      3.4                pyhd8ed1ab_0    conda-forge
jinja2                    3.1.2              pyhd8ed1ab_1    conda-forge
ld_impl_linux-64          2.39                 hcc3a1bd_1    conda-forge
libarchive                3.6.1                h648a969_0    conda-forge
libffi                    3.4.2                h7f98852_5    conda-forge
libgcc-ng                 12.2.0              h65d4601_19    conda-forge
libgomp                   12.2.0              h65d4601_19    conda-forge
libiconv                  1.17                 h166bdaf_0    conda-forge
liblief                   0.12.3               h27087fc_0    conda-forge
libnsl                    2.0.0                h7f98852_0    conda-forge
libsqlite                 3.40.0               h753d276_0    conda-forge
libstdcxx-ng              12.2.0              h46fd767_19    conda-forge
libuuid                   2.32.1            h7f98852_1000    conda-forge
libxml2                   2.10.3               h7463322_0    conda-forge
libzlib                   1.2.13               h166bdaf_4    conda-forge
lz4-c                     1.9.3                h9c3ff4c_1    conda-forge
lzo                       2.10              h516909a_1000    conda-forge
markupsafe                2.1.1           py311hd4cff14_2    conda-forge
ncurses                   6.3                  h27087fc_1    conda-forge
openssl                   3.0.7                h166bdaf_0    conda-forge
patch                     2.7.6             h7f98852_1002    conda-forge
patchelf                  0.17.0               h58526e2_0    conda-forge
pip                       22.3.1             pyhd8ed1ab_0    conda-forge
pkginfo                   1.8.3              pyhd8ed1ab_0    conda-forge
psutil                    5.9.4           py311hd4cff14_0    conda-forge
py-lief                   0.12.3          py311ha362b79_0    conda-forge
pycosat                   0.6.4           py311hd4cff14_1    conda-forge
pycparser                 2.21               pyhd8ed1ab_0    conda-forge
pyopenssl                 22.1.0             pyhd8ed1ab_0    conda-forge
pysocks                   1.7.1              pyha2e5f31_6    conda-forge
python                    3.11.0          ha86cf86_0_cpython    conda-forge
python-libarchive-c       4.0             py311h38be061_2    conda-forge
python_abi                3.11                    3_cp311    conda-forge
pytz                      2022.6             pyhd8ed1ab_0    conda-forge
pyyaml                    6.0             py311hd4cff14_5    conda-forge
readline                  8.1.2                h0f457ee_0    conda-forge
requests                  2.28.1             pyhd8ed1ab_1    conda-forge
ripgrep                   13.0.0               h2f28480_2    conda-forge
ruamel_yaml               0.15.80         py311hd4cff14_1008    conda-forge
setuptools                65.5.1             pyhd8ed1ab_0    conda-forge
six                       1.16.0             pyh6c4a22f_0    conda-forge
soupsieve                 2.3.2.post1        pyhd8ed1ab_0    conda-forge
tk                        8.6.12               h27826a3_0    conda-forge
toml                      0.10.2             pyhd8ed1ab_0    conda-forge
toolz                     0.12.0             pyhd8ed1ab_0    conda-forge
tqdm                      4.64.1             pyhd8ed1ab_0    conda-forge
tzdata                    2022f                h191b570_0    conda-forge
urllib3                   1.26.11            pyhd8ed1ab_0    conda-forge
wheel                     0.38.4             pyhd8ed1ab_0    conda-forge
xz                        5.2.6                h166bdaf_0    conda-forge
yaml                      0.2.5                h7f98852_2    conda-forge
zstd                      1.5.2                h6239696_4    conda-forge

Additional Context

This was discovered after conda-forge switched over to using the .conda format.
See conda-forge/conda-forge.github.io#1586 for an overview of that.
@mbargull mbargull added the type::bug describes erroneous operation, use severity::* to classify the type label Nov 24, 2022
mbargull added a commit to mbargull/conda-build that referenced this issue Nov 24, 2022
@mbargull
Add test for zstd compression level, condagh-4649
91767dd
@mbargull mbargull mentioned this issue Nov 24, 2022
Merged
3 tasks
@jezdez jezdez added backlog issue has been triaged but has not been earmarked for any upcoming release good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward severity::1 blocker; broken functionality with no workaround source::community catch-all for issues filed by community members tag::performance related to degraded performance labels Nov 24, 2022
mbargull added a commit to mbargull/conda-build that referenced this issue Nov 24, 2022
@mbargull
Add test for zstd compression level, condagh-4649
f4599bc
@mbargull mbargull changed the title conda_build.main_build overrides zstd_compression_level from condarc with the default value conda-build CLI overrides condarc's zstd_compression_level with the default value Nov 24, 2022
mbargull added a commit to mbargull/conda-build that referenced this issue Nov 25, 2022
@mbargull
Add test for zstd compression level, condagh-4649
1753189
@travishathaway travishathaway added this to the 3.23.2 milestone Nov 29, 2022
jezdez pushed a commit that referenced this issue Nov 29, 2022
@mbargull
conda-build CLI overrode condarc's zstd_compression_level with the de…
05dc55a 
…fault value (#4650)

Fix #4649.
@jezdez jezdez moved this to Done in 🧭 Planning Nov 29, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward locked [bot] locked due to inactivity severity::1 blocker; broken functionality with no workaround source::community catch-all for issues filed by community members tag::performance related to degraded performance type::bug describes erroneous operation, use severity::* to classify the type
Projects
🧭 Planning
Archived in project
Milestone
3.23.2
3 participants
@jezdez @travishathaway @mbargull