Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_license_family.py: combine tests into parameterized test #4683

Merged
merged 2 commits into from
Jan 4, 2023
Merged

test_license_family.py: combine tests into parameterized test #4683

merged 2 commits into from
Jan 4, 2023

Conversation

kenodegard
Copy link
Contributor

Description

Several tests were duplicated. Refactored into a pytest parameterized implementation.

Xref #4590

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added source::anaconda created by members of Anaconda, Inc. in-progress issue is actively being worked on labels Dec 22, 2022
@kenodegard kenodegard self-assigned this Dec 22, 2022
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 22, 2022
@kenodegard kenodegard mentioned this pull request Dec 22, 2022
Closed
46 tasks
sven6002
sven6002 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@sven6002 sven6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we didn't need a whole bunch of them.. fantastic..

@kenodegard kenodegard mentioned this pull request Dec 22, 2022
Closed
@kenodegard kenodegard merged commit ebda76c into conda:main Jan 4, 2023
@kenodegard kenodegard deleted the test_license_family branch January 4, 2023 20:50
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sven6002 sven6002 sven6002 approved these changes

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenodegard @sven6002 @conda-bot