Inline fixtures in tests/test_variants.py
#4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python specific variant is an insignificant detail that adds confusion to what the test is targeting.
This fixture is only used once, bring it inline for simpler code. Furthermore, the test using this fixture is broken and needs to be investigated separately.
Combines test_get_package_variants_from_file and test_get_package_variants_from_dictionary_of_lists and parameterize them since they contain the same assertions for different inputs (yaml or dict).
conda-bot
added
the
cla-signed
This was referenced Jan 18, 2023
beeankha
approved these changes
Jan 18, 2023
beeankha
added
in-progress
beeankha
added a commit
to beeankha/conda-build
that referenced
this pull request
Jan 19, 2023
beeankha
added a commit
to beeankha/conda-build
that referenced
this pull request
Jan 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following fixtures had limit usage and benefitted from being inlined:
numpy_version_ignoredsingle_versionno_numpy_versionChecklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?