Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize test_os_utils_external.py::test_find_executable test and add Windows support #4727

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Minimize test_os_utils_external.py::test_find_executable test and add Windows support #4727

merged 1 commit into from
Jan 18, 2023

Conversation

kenodegard
Copy link
Contributor

Description

Rewrote tests/test_os_utils_external.py::test_find_executable more compactly and added missing Windows support (see original PR #1899).

Xref #4590

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added the source::anaconda created by members of Anaconda, Inc. label Jan 18, 2023
@kenodegard kenodegard requested a review from sven6002 January 18, 2023 01:26
@kenodegard kenodegard self-assigned this Jan 18, 2023
@kenodegard kenodegard mentioned this pull request Jan 18, 2023
Closed
46 tasks
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 18, 2023
@travishathaway travishathaway merged commit 47af17a into conda:main Jan 18, 2023
@kenodegard kenodegard deleted the test_os_utils_external branch January 18, 2023 15:24
@beeankha beeankha added in-progress issue is actively being worked on and removed in-progress issue is actively being worked on labels Jan 19, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcelotrevisani marcelotrevisani marcelotrevisani approved these changes

@sven6002 sven6002 Awaiting requested review from sven6002

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kenodegard @marcelotrevisani @travishathaway @conda-bot @beeankha