Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_api_skeleton_cran.py: Inline parametrize, use pathlib, update CRAN packages #4736

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jan 20, 2023

Description

Inline parameterized logic. Switches from os.path to pathlib. Replace select CRAN packages in favor of smaller packages (with identical licenses) for faster testing:

Old CRAN Old Runs New CRAN New Runs
r-badger 190.31s r-fastdigest 24.27s
r-udpipe 28.82s r-tokenizers.bpe 23.67s
r-zoo 24.65s r-base64enc 7.71s

Xref #4549 #4590

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added the source::anaconda created by members of Anaconda, Inc. label Jan 20, 2023
@kenodegard kenodegard requested a review from sven6002 January 20, 2023 16:12
@kenodegard kenodegard self-assigned this Jan 20, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 20, 2023
This was referenced Jan 20, 2023
@jezdez jezdez merged commit 7b25006 into conda:main Jan 26, 2023
@kenodegard kenodegard deleted the test_api_skeleton_cran branch January 26, 2023 15:08
sven6002 pushed a commit that referenced this pull request Jan 31, 2023
…CRAN packages (#4736)

* Inline parametrize, use pathlib, update CRAN packages

Use smaller CRAN packages for faster downloads.

* Additional type hinting
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants