Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_develop.py: Refactor to use pathlib & abstract tests #4739

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

kenodegard
Copy link
Contributor

Description

Replace os.path with pathlib. Updated fixtures. Refactor tests for simpler implementation.

Xref #4590

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added the source::anaconda created by members of Anaconda, Inc. label Jan 21, 2023
@kenodegard kenodegard requested a review from sven6002 January 21, 2023 00:09
@kenodegard kenodegard self-assigned this Jan 21, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 21, 2023
@kenodegard kenodegard mentioned this pull request Jan 21, 2023
46 tasks
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like rm_rf can't handle pathlib paths :-/

tests/test_develop.py Outdated Show resolved Hide resolved
tests/test_develop.py Outdated Show resolved Hide resolved
@jezdez
Copy link
Member

jezdez commented Jan 26, 2023

@kenodegard Can you file a ticket in conda to fix rm_rf?

@kenodegard
Copy link
Contributor Author

@jezdez added an epic to add pathlib support conda/conda#12281

@jezdez jezdez enabled auto-merge (squash) January 26, 2023 20:51
@jezdez jezdez merged commit 3e35465 into conda:main Jan 27, 2023
@kenodegard kenodegard deleted the test_develop branch January 27, 2023 05:21
sven6002 pushed a commit that referenced this pull request Jan 31, 2023
* Refactor to use pathlib & abstract tests

* Move duplicate paths into global DEVELOP_PATHS

* rm_rf doesn't support pathlib
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants