-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_develop.py
: Refactor to use pathlib & abstract tests
#4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
jezdez
approved these changes
Jan 26, 2023
jezdez
requested changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like rm_rf can't handle pathlib paths :-/
@kenodegard Can you file a ticket in conda to fix rm_rf? |
@jezdez added an epic to add |
jezdez
approved these changes
Jan 26, 2023
sven6002
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Refactor to use pathlib & abstract tests * Move duplicate paths into global DEVELOP_PATHS * rm_rf doesn't support pathlib
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
[bot] added once the contributor has signed the CLA
locked
[bot] locked due to inactivity
source::anaconda
created by members of Anaconda, Inc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace os.path with pathlib. Updated fixtures. Refactor tests for simpler implementation.
Xref #4590
Checklist - did you ...
Add a file to thenews
directory (using the template) for the next release's release notes?Add / update outdated documentation?