Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_api_render.py: remove unused skipif and converted unittest.mock to pytest-mocker #4747

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

kenodegard
Copy link
Contributor

Description

Removed pytest.mark.skipif conditions for Python 3+ codes.

Removed test (test_run_exports_from_repo_without_channeldata) marked as pytest.mark.xfail and never had its recipe files (tests/test-recipes/metadata/_run_export_no_channeldata) committed when originally added in 2019 (see #3596). Furthermore, the test was designed to only run on Linux + Python 2 (pytest.mark.skipif(sys.platform != "linux2")), which is no longer supported.

Xref #4590

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added the source::anaconda created by members of Anaconda, Inc. label Jan 24, 2023
@kenodegard kenodegard requested a review from sven6002 January 24, 2023 03:18
@kenodegard kenodegard self-assigned this Jan 24, 2023
@kenodegard kenodegard mentioned this pull request Jan 24, 2023
46 tasks
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 24, 2023
@jezdez jezdez merged commit e276372 into conda:main Jan 26, 2023
@kenodegard kenodegard deleted the test_api_render branch January 26, 2023 15:08
sven6002 pushed a commit that referenced this pull request Jan 31, 2023
…mock` to pytest-mocker (#4747)

* Converted unittest.mock to pytest mocker

* Remove unnecessary skipif for Python 2.7
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants