Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_api_skeleton.py: Reorg fixtures, remove pre-Python 2.7 condition, require ruamel.yaml #4748

Merged
merged 8 commits into from
Jan 27, 2023

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jan 24, 2023

Description

Grouped fixtures at the top of the file. Remove pre-Python 2.7 condition. Require ruamel.yaml to avoid try-except.

Xref #4590

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added the source::anaconda created by members of Anaconda, Inc. label Jan 24, 2023
@kenodegard kenodegard requested a review from sven6002 January 24, 2023 04:58
@kenodegard kenodegard self-assigned this Jan 24, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 24, 2023
@kenodegard kenodegard mentioned this pull request Jan 24, 2023
46 tasks
jezdez
jezdez previously approved these changes Jan 26, 2023
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, but nothing serious

tests/test_api_skeleton.py Show resolved Hide resolved
tests/test_api_skeleton.py Outdated Show resolved Hide resolved
tests/test_api_skeleton.py Outdated Show resolved Hide resolved
@jezdez jezdez enabled auto-merge (squash) January 26, 2023 20:51
@jezdez jezdez merged commit cb4fb0a into conda:main Jan 27, 2023
@kenodegard kenodegard deleted the test_api_skeleton branch January 27, 2023 17:13
sven6002 pushed a commit that referenced this pull request Jan 31, 2023
…on, require `ruamel.yaml` (#4748)

* Require ruamel.yaml

* Inline parameterization and update skipif

* Move fixtures to the top

* Remove pre-Python 2.7 condition

* Add missing future import

* Convert all skeletonize/render to use tmp_path

* Fix wording and include link to lua GH issue
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants