Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI adjustments for conda-libmamba-solver as default #5059

Merged
merged 6 commits into from
Nov 17, 2023
Merged

CI adjustments for conda-libmamba-solver as default #5059

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a23e25
mark unicode_all_over as xfail
jaimergp Nov 7, 2023
33e6523
add news
jaimergp Nov 10, 2023
082b5f5
pre-commit
jaimergp Nov 10, 2023
031dac4
Replace tempfile.TemporaryDirectory with tmp_path
kenodegard Nov 17, 2023
d636ec9
Update testing_workdir using tmp_path & monkeypatch
kenodegard Nov 17, 2023
e0a468c
Merge branch 'main' into try-cls-default
kenodegard Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions news/5059-ci-conda-libmamba-solver
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* <news item>

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* Mark Unicode tests as incompatible with `libmamba`. (#5059)
4 changes: 4 additions & 0 deletions tests/test_api_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
CondaError,
LinkError,
cc_conda_build,
context,
reset_context,
url_path,
)
Expand Down Expand Up @@ -123,6 +124,9 @@ def test_recipe_builds(
# ``source_setup_py_data_subdir`` reproduces the problem.
if recipe.name == "source_setup_py_data_subdir":
pytest.xfail("Issue related to #3754 on conda-build.")
elif recipe.name == "unicode_all_over" and context.solver == "libmamba":
pytest.xfail("Unicode package names not supported in libmamba.")
Copy link
Contributor

@dholth dholth Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too bad.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libmamba doesn't support unicode package names IIUC, no need to test for it.


# These variables are defined solely for testing purposes,
# so they can be checked within build scripts
testing_config.activate = True
Expand Down
Loading