-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pkgs cache on Windows #5082
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make more sense to use GNU tar instead to work around the performance issue: actions/cache#752 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually nevermind, getsentry/sentry-dotnet#1647 seems to indicate it wasn't fixed by switching to gnu tar.
Ah, I forgot to comment on this one, sorry. |
https://learn.microsoft.com/en-us/virtualization/community/team-blog/2017/20171219-tar-and-curl-come-to-windows seems to indicate that bsdtar is coming to Windows builds, based on libarchive, which may fix this. We could try to install it from somewhere else? |
I've just applied |
Aha! When putting conda's package dir on D: instead of C: then it's fast to unpack! Courtesy of actions/setup-go#393 ~40 seconds instead of ~6 minutes! |
.github/workflows/tests.yml
Outdated
uses: conda-incubator/setup-miniconda@v2 | ||
uses: jezdez/setup-miniconda@windows-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little nasty, I'll try to upstream this to setup-miniconda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use CONDA_PKGS_DIRS
env var in the meantime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it needs to be recorded in the config, I see.
cb8bb01
to
6c73a45
Compare
Ported that to setup-miniconda: conda-incubator/setup-miniconda#328 |
Description
conda-build's CI uses
actions/cache
to restore the pkgs cache conda uses to provision the environments. On Unix this takes a few seconds, but on Windows this goes all they way to 6-10mins! Apparently it's caused by tar's slowness (see actions/cache#752).If this is to save time, I'd say it's not fitting that purpose. If it's to save Anaconda some traffic, then feel free to close.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?