Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSVC-built win-arm64 launchers #5545

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added conda_build/cli-arm64.exe
Binary file not shown.
3 changes: 2 additions & 1 deletion conda_build/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,8 @@ def create_exe_file(directory, executable, target_platform):

if target_platform.endswith("32"):
executable_file = os.path.join(exe_directory, "cli-32.exe")

if target_platform.endswith("arm64"):
executable_file = os.path.join(exe_directory, "cli-arm64.exe")
else:
executable_file = os.path.join(exe_directory, "cli-64.exe")

Expand Down
Binary file added conda_build/gui-arm64.exe
Binary file not shown.
2 changes: 1 addition & 1 deletion conda_build/noarch_python.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def transform(m, files, prefix):

# copy in windows exe shims if there are any python-scripts
if d["python-scripts"]:
for fn in "cli-32.exe", "cli-64.exe":
for fn in "cli-32.exe", "cli-64.exe", "cli-arm64.exe":
shutil.copyfile(join(this_dir, fn), join(prefix, fn))

# Read the local _link.py
Expand Down
10 changes: 9 additions & 1 deletion tests/test_codesigned.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,15 @@ def signtool_unsupported() -> bool:

@pytest.mark.skipif(signtool_unsupported(), reason=signtool_unsupported_because())
@pytest.mark.parametrize(
"stub_file_name", ["cli-32.exe", "cli-64.exe", "gui-32.exe", "gui-64.exe"]
"stub_file_name",
[
"cli-32.exe",
"cli-64.exe",
"cli-arm64.exe",
"gui-32.exe",
"gui-64.exe",
"gui-arm64.exe",
],
)
def test_stub_exe_signatures(stub_file_name: str) -> None:
"""Verify that signtool verifies the signature of the stub exes"""
Expand Down
Loading