-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda's Prefixes Blogpost #148
Conversation
868dcea
to
2dca51b
Compare
✅ Deploy Preview for conda-dot-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e4b78d0
to
4c34468
Compare
4c34468
to
b291bce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a few comments/questions/suggestions. This is a cool deep dive, Ken.
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
2cca534
to
f918411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment. This feels a lot better to me, Ken. Thanks for working through my questions!
031f498
to
345bbf5
Compare
345bbf5
to
b0f769d
Compare
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
"@docusaurus/core": "^3.3.2", | ||
"@docusaurus/plugin-ideal-image": "^3.3.2", | ||
"@docusaurus/preset-classic": "^3.3.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped to docusaurus>3.2.0
to benefit from facebook/docusaurus#9581 which allows for local author images.
One more thought, the list kind of disappears with all the other stuff on the page. What if each list item was an H2 header or something? |
Co-authored-by: Bianca Henderson <beeankha@gmail.com>
@kathatherine I've switched it to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
blog/2024-05-14-prefixes.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to be mdx
? I don't see any JSX in this post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like only 3 of our prior posts need JSX (imports for images, which I suspect isn't necessary)
I've just been sticking to a standard format 🤷🏼♂️
Is there a downside to using mdx
even if we don't use JSX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @kenodegard! Thanks for writing it. A few suggestions.
Co-authored-by: Paul Yim <pseudoyim@users.noreply.github.com>
Description
A blogpost discussing the recent research into the various conda prefixes (conda/conda#12704).