Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda's Prefixes Blogpost #148

Merged
merged 16 commits into from
May 20, 2024
Merged

Conversation

kenodegard
Copy link
Contributor

Description

A blogpost discussing the recent research into the various conda prefixes (conda/conda#12704).

@kenodegard kenodegard self-assigned this Jun 17, 2023
Copy link

netlify bot commented May 8, 2024

Deploy Preview for conda-dot-org ready!

Name Link
🔨 Latest commit ad1a12e
🔍 Latest deploy log https://app.netlify.com/sites/conda-dot-org/deploys/664b8900365f8a0008f38c24
😎 Deploy Preview https://deploy-preview-148--conda-dot-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@conda conda deleted a comment from netlify bot May 8, 2024
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a few comments/questions/suggestions. This is a cool deep dive, Ken.

blog/2024-05-08-prefixes.mdx Outdated Show resolved Hide resolved
blog/2024-05-08-prefixes.mdx Outdated Show resolved Hide resolved
blog/2024-05-08-prefixes.mdx Outdated Show resolved Hide resolved
blog/2024-05-08-prefixes.mdx Outdated Show resolved Hide resolved
blog/2024-05-08-prefixes.mdx Outdated Show resolved Hide resolved
blog/2024-05-08-prefixes.mdx Outdated Show resolved Hide resolved
blog/2024-05-08-prefixes.mdx Outdated Show resolved Hide resolved
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@kenodegard kenodegard force-pushed the prefixes-blogpost branch 4 times, most recently from 2cca534 to f918411 Compare May 8, 2024 21:12
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment. This feels a lot better to me, Ken. Thanks for working through my questions!

blog/2024-05-08-prefixes.mdx Outdated Show resolved Hide resolved
@kenodegard kenodegard force-pushed the prefixes-blogpost branch 7 times, most recently from 031f498 to 345bbf5 Compare May 8, 2024 21:38
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@kenodegard kenodegard marked this pull request as ready for review May 8, 2024 21:42
Comment on lines +20 to +22
"@docusaurus/core": "^3.3.2",
"@docusaurus/plugin-ideal-image": "^3.3.2",
"@docusaurus/preset-classic": "^3.3.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to docusaurus>3.2.0 to benefit from facebook/docusaurus#9581 which allows for local author images.

@kathatherine
Copy link
Contributor

One more thought, the list kind of disappears with all the other stuff on the page. What if each list item was an H2 header or something?

kenodegard and others added 2 commits May 10, 2024 13:33
Co-authored-by: Bianca Henderson <beeankha@gmail.com>
@kenodegard
Copy link
Contributor Author

@kathatherine I've switched it to use h3 instead of a list, does that help? I also tested using h2 but the text got too big and started to line wrap

Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be mdx? I don't see any JSX in this post.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like only 3 of our prior posts need JSX (imports for images, which I suspect isn't necessary)

I've just been sticking to a standard format 🤷🏼‍♂️

Is there a downside to using mdx even if we don't use JSX?

Copy link
Contributor

@pseudoyim pseudoyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @kenodegard! Thanks for writing it. A few suggestions.

blog/2024-05-14-prefixes.mdx Outdated Show resolved Hide resolved
blog/2024-05-14-prefixes.mdx Outdated Show resolved Hide resolved
blog/2024-05-14-prefixes.mdx Outdated Show resolved Hide resolved
Co-authored-by: Paul Yim <pseudoyim@users.noreply.github.com>
@kenodegard kenodegard merged commit 22cc03f into conda:main May 20, 2024
6 checks passed
@kenodegard kenodegard deleted the prefixes-blogpost branch May 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants