Add devcontainer integrations #451
Conversation
conda-bot
added
the
cla-signed
|
Obviously I love the idea 😄. Since this requires a couple of repos, when I was thinking about this in the context of the conda devcontainers PR, I was wondering if it makes sense to create a dedicated workspace repo, with the other three repos as submodules and the overarching workspace definition along with devcontainers in the repo root. |
That could be a good setup, but given how unlikely it is that we develop CLS in isolation (we will mostly test against conda, or debug conda/conda upstream tests, etc), I think for now we are good with assuming that
Didn't try it yet. I was mostly copying fragments from different files into the new places, but then found out that it'd be better to tackle the CI renovation before this one. I'll ping when this is ready for review, sorry for the noise! |
|
Failures due to the |
jaimergp
requested review from
zklaus and
jezdez
and removed request for
zklaus
.devcontainer/post_create.sh
Outdated
| if [ ! -f $CONDA_SRC/pyproject.toml ]; then | ||
| echo "conda/conda not found, cloning..." | ||
| git clone https://github.com/conda/conda $CONDA_SRC | ||
| fi |
There was a problem hiding this comment.
I think it's better to bail with an error. There are situations where a user may have their working directory in place but without a pyproject.toml file. In other cases, someone may have their conda sources in a different place. That will not work with this setup, of course, but then it's better for them to notice.
There was a problem hiding this comment.
Good point. Added.
.devcontainer/post_start.sh
Outdated
|
|
||
| set -euo pipefail | ||
|
|
||
| MINICONDA=${MINICONDA:-/opt/conda} |
There was a problem hiding this comment.
In l 23 we write that Miniconda is not compatible with Mamba. Would it be better to use a different variable name here, like BASE_PREFIX or similar?
There was a problem hiding this comment.
Good catch. Adjusted all the env var names for clarity.
docs/dev/setup.md
Outdated
There was a problem hiding this comment.
Do we want to remove the docker version of the setup or keep it as an alternative?
There was a problem hiding this comment.
I haven't tested it manually, but I guess one could also pull from condaforge/miniforge, mount volumes and then run post_create and post_start? I'll add it as a section.
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@quansight.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@quansight.com>
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@quansight.com>
Description
Based on conda/conda#13648
Makes everything super easy ✨ in VS Code. I don't know why we didn't set this up earlier!
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?