Fix an issue when specifying full wheel URLs for a pypi package. #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pypi solver expects hashes to be provided as part of the URL but, in most cases, if a user provides a URL for a package, they will not provide one with a hash. This PR ignores the missing hash instead of crashing. A test was added that fails prior to this change and succeeds after.
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I am not sure why that one test failed. Feels like more of a fluke and unrelated to the PR. |
maresb
requested changes
Dec 8, 2023
Indeed, I suspect that there's an out-of-memory condition or similar that occasionally causes a cascade of failures like that. Upon rerunning it's passing again. |
Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
|
Thanks for the super quick review. Accepted all changes. |
maresb
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pypi solver expects hashes to be provided as part of the URL but, in most cases, if a user provides a URL for a package, they will not provide one with a hash. This PR ignores the missing hash instead of crashing.
A test was added that fails prior to this change and succeeds after.