Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Windows prefix changes #190

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fixes to Windows prefix changes #190

merged 1 commit into from
Jan 18, 2022

Conversation

guilhermebs
Copy link
Contributor

@guilhermebs guilhermebs commented Sep 9, 2021

I have recently started observing that conda-unpack was not properly fixing prefixes of entry points in Windows packages installed with pip install ..
This is because conda-pack assumes that the placeholder is in lower-case. But by inspecting the entry point binary I found this not to be the case. This PR solves the issue by trying to fix the entry point using both lower-case and mixed-case forms of the placeholder.

environment:

ca-certificates           2021.7.5             haa95532_1
certifi                   2021.5.30        py39haa95532_0
openssl                   1.1.1l               h2bbff1b_0
pip                       21.2.4           py38haa95532_0
python                    3.9.6                h6244533_1
setuptools                52.0.0           py39haa95532_0
snake                     1.0                      pypi_0    pypi  <--- my package installed with `pip install .`, link: https://github.com/guilhermebs/CondaNSIS/tree/main/example/package
sqlite                    3.36.0               h2bbff1b_0
tzdata                    2021a                h5d7bf9c_0
vc                        14.2                 h21ff451_1
vs2015_runtime            14.27.29016          h5e58377_2
wheel                     0.37.0             pyhd3eb1b0_1
wincertstore              0.2              py39h2bbff1b_0

@anaconda-issue-bot
Copy link

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @guilhermebs. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@guilhermebs guilhermebs marked this pull request as ready for review September 9, 2021 08:54
@jezdez
Copy link
Member

jezdez commented Sep 14, 2021

@anaconda-issue-bot check

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 14, 2021
@dbast dbast merged commit 34f8c8a into conda:master Jan 18, 2022
@dbast
Copy link
Member

dbast commented Jan 18, 2022

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants