codesign binaries on osx-arm64 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
2 tasks
|
This has been tested locally but as there is no Apple Silicon Github runner yet, we won't be able to test it in CI. |
dbast
previously approved these changes
Mar 16, 2023
jaimergp
reviewed
Mar 17, 2023
Comment on lines
+81
to
+83
| subprocess.run( | ||
| ["/usr/bin/codesign", "-s", "-", "-f", path], capture_output=True | ||
| ) |
There was a problem hiding this comment.
Should the output be logged if the command failed? Something like:
Suggested change
| subprocess.run( | |
| ["/usr/bin/codesign", "-s", "-", "-f", path], capture_output=True | |
| ) | |
| process = subprocess.run( | |
| ["/usr/bin/codesign", "-s", "-", "-f", path], capture_output=True, text=True, | |
| ) | |
| if process.returncode: | |
| log.debug("codesign failed for '%s'.\nstdout:\n%s\nstderr:\n%s", path, process.stdout, process.stderr) |
There was a problem hiding this comment.
I'm keeping the same behaviour here as we do in conda: https://github.com/conda/conda/blob/a3648d7b58175fd505b3176e45e3485c6d2ea571/conda/core/portability.py#L87
I can add that logging but it will probably never pop to the user with being on debug level.
jaimergp
reviewed
Mar 17, 2023
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
|
@conda/constructor This is ready for review. |
|
@dbast Can you have a look at this again? |
jaimergp
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?