squashfs: Correct root dir permissions consistency by using a subdirectoy #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jezdez
force-pushed
the
squashfs_root_permissions
branch
from
747c287 to
1790fab
Compare
mkdtemp always creates directories with 0700. Using a subdirectory keeps the image root directory more consistent with the permissions for all other directories created in the image.
rafiyr
force-pushed
the
squashfs_root_permissions
branch
from
1790fab to
c8d3b52
Compare
xhochy
changed the title
xhochy
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkdtemp always creates directories with 0700. Using a subdirectory keeps the image root directory more consistent with the permissions for all other directories created in the image.
Adding an extra level may seem a bit hacky, but it avoids breaking the safety semantics of locking down temp dirs and avoids having to add more logic to figure out what permissions adjustments to make after creating the temp dir.
mksquashfs preserves the permissions and ownership of the staging dir. By default squashfuse ignores the access limitations, However, that is optional for squashfuse and by default the kernel driver will also respect the embedded permissions.