Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-archive format for fast environment clone #320

Merged
merged 5 commits into from
May 6, 2024
Merged

Conversation

ayurchuk
Copy link
Contributor

Existing formats do not provide a straightforward way to clone the environment without making an intermediate archive. Even with disabled compression, they impact execution time and use extra disk space. The no-archive is a new format that addresses both aspects. It is 4x faster for local environment cloning on basic scenarios (i.e. github.com/idamlaj/dist-demo) and uses no extra disk space.

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @ayurchuk.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#900), and ping the bot to refresh the PR.

@ayurchuk ayurchuk marked this pull request as ready for review March 29, 2024 15:16
@ayurchuk ayurchuk requested review from xhochy and a team as code owners March 29, 2024 15:16
@ayurchuk
Copy link
Contributor Author

ayurchuk commented Apr 5, 2024

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 5, 2024
@xhochy
Copy link
Collaborator

xhochy commented Apr 7, 2024

@ayurchuk See the failing unit tests.

@ayurchuk
Copy link
Contributor Author

@xhochy thanks, should be addressed now. Side question, what is the best way to trigger tests on the PR?

@xhochy
Copy link
Collaborator

xhochy commented Apr 20, 2024

As this is your first PR to the repository, a maintainer needs to approve the run first on each new commit.

@ayurchuk
Copy link
Contributor Author

@xhochy I'm wondering if there is any page on how to run test suite locally

conda_pack/formats.py Outdated Show resolved Hide resolved
Andriy Yurchuk and others added 3 commits May 4, 2024 17:53
Existing formats do not provide a straightforward way to clone the environment without making an intermediate archive.
Even with disabled compression, they impact execution time and use extra disk space.
The no-archive is a new format that addresses both aspects.
It is 4x faster for local environment cloning on basic scenarios (i.e. github.com/idamlaj/dist-demo) and uses no extra disk space.
Copy link
Collaborator

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xhochy xhochy merged commit 6803cdb into conda:main May 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants