-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activate.fish: support activating conda in fish shells #342
Conversation
We require contributors to sign our Contributor License Agreement and we don't have one on file for @d4l3k. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#956), and ping the bot to refresh the PR. |
I signed the CLA |
@d4l3k The tests are sadly failing in CI |
@xhochy tests should be passing now -- I added fish as a conda-forge dep to the tests worklfow |
It still fails, we probably need to skip it on Windows. |
@xhochy updated it to only install fish on mac/linux. test_activate is passing on mac/linux. The failing mac test only failed on Py3.8 and seems to be flakiness unrelated to this PR. |
@xhochy seems like all but 1 test is passing now. Looking at that failure I'm not sure how this PR could have caused it since I don't think I touched anything related to that file. Would appreciate your help in debugging this I also don't have access to a mac environment where I could debug this locally |
Everything looks good now, needs someone to merge the CLA though (I cannot do that) |
@conda-bot check |
Should be good to go. Sorry for the delay! |
Description
This adds support for the fish shell #72
Test plan:
manual tests
Checklist - did you ...
news
directory (using the template) for the next release's release notes?