Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance when linking files using rayon #985

Merged
merged 19 commits into from
Dec 16, 2024

Conversation

baszalmstra
Copy link
Collaborator

Description

@wolfv wolfv changed the title Perf/rayon2 feat: improve performance when linking files using rayon Dec 16, 2024
@baszalmstra baszalmstra marked this pull request as ready for review December 16, 2024 11:53
@@ -375,7 +375,7 @@ impl<F: ProgressFormatter> IndicatifReporterInner<F> {
.iter()
.map(|&idx| (self.package_sizes[idx], &self.package_names[idx]));

let largest_package = package_iter.max_by_key(|(size, _)| *size);
let largest_package = package_iter.min_by_key(|(size, _)| *size);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeaaah I added this to make it look for the users as if more stuff is happening. The biggest package will take the longest. This changes that the user instead sees way more packages in the loading bar.

@wolfv wolfv merged commit 2f571eb into conda:main Dec 16, 2024
14 of 15 checks passed
@baszalmstra baszalmstra mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants