Fix deprecation warnings #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tks. |
|
@AJenbo When you have time can you help me to fix the remaining 12 warnings? Tks |
|
K, but you have to test and fix any issues with it your self. I don't have time for that part. |
|
OK. Tks for help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all a function does it forward the call to the parent then there isn't actually a need to implement it, since methods are inherited.
After this change the action is able to progress to the PHPStan portion and report on the detected level 0 issues. I fixed about 1/3 of the issues but there are still 44 left. Good luck.