Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Tests should run in head branch #151

Merged
merged 1 commit into from
Sep 18, 2024
Merged

FIX: Tests should run in head branch #151

merged 1 commit into from
Sep 18, 2024

Conversation

jmigueprieto
Copy link
Contributor

@jmigueprieto jmigueprieto commented Sep 18, 2024 •
edited
Loading

With #149 changes the tests (including integration tests) run on PRs from forked repos.

However, I missed this in the checkout, so they are running on main.

with:
      ref: ${{ github.event.workflow_run.head_branch }}

@jmigueprieto jmigueprieto self-assigned this Sep 18, 2024
@jmigueprieto jmigueprieto merged commit fa5b7a8 into main Sep 18, 2024
1 check passed
@jmigueprieto jmigueprieto deleted the fix/tests-should-run-on-head-branch branch September 18, 2024 03:20
@jmigueprieto jmigueprieto mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codehackerr codehackerr codehackerr approved these changes

@v1r3n v1r3n Awaiting requested review from v1r3n

@c4lm c4lm Awaiting requested review from c4lm

Assignees

@jmigueprieto jmigueprieto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmigueprieto @codehackerr